On 02/28/2017 02:41 PM, Jason Merrill wrote:
On Tue, Feb 28, 2017 at 12:48 PM, Jakub Jelinek <ja...@redhat.com> wrote:
The DR1659/DR1611 changes result in construct_virtual_base not being called,
but unfortunately the call generated in there was the spot that caused
mark_exp_read on the arguments passed to the vbase construction (TREE_USED
is set on these earlier already during parsing them). That results
in false positive -Wunused-but-set-parameter warnings.
The following patch tries to avoid the warning in that case by marking
the arguments as read (essentially pretending they were read in the omitted
call). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
I believe there's some question still about whether the DR1659/11
changes are what we want; I'll defer to Nathan on this patch.
Jakub's patch is OK. The defect I've reported is how 1658 interacts with
virtual destructors. (bug 79393)
nathan
--
Nathan Sidwell
