On Tue, Feb 14, 2017 at 09:36:44AM -0700, Martin Sebor wrote:
> > @@ -1371,7 +1354,8 @@ format_integer (const directive &dir, tr
> > else
> > {
> > res.range.likely = res.range.min;
> > - if (likely_adjust && maybebase && base != 10)
> > + if (maybebase && base != 10
> > + && (tree_int_cst_sgn (argmin) < 0 || tree_int_cst_sgn (argmax) > 0))
> > {
> > if (res.range.min == 1)
> > res.range.likely += base == 8 ? 1 : 2;
>
> You've removed all the comments that explain what's going on. If
> you must make the change (I see no justification for it now) please
> at least document it.
I thought that is the:
/* Add the adjustment for an argument whose range includes zero
since it doesn't include the octal or hexadecimal base prefix. */
comment above the if.
Jakub
