On Mon, Feb 13, 2017 at 11:41:48AM -0500, Nathan Sidwell wrote: > On 02/13/2017 10:46 AM, Jakub Jelinek wrote: > > Hi! > > > > I'd like to ping a couple of patches: > > > > - C++ P1 PR79232 - ICEs and wrong-code with COMPOUND_EXPR on lhs of > > assignment > > http://gcc.gnu.org/ml/gcc-patches/2017-01/msg02341.html > > What puzzles me about (and may be an existing orthogonal issue), is the > checking for TYPE(rhs) == VOID. In the current code it's only explicitly > checked in the lhs == COND_EXPR case, which is strange. Why isn't it a > general constraint?
I'll double check; copied this from the COND_EXPR case which had the same. I believe the reason is that this is (or ought to be) checked later on, but stabilitize_expr wouldn't work well if it is called with a void expression. Jakub