On Feb 7, 2017, at 2:20 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:
> No. In fact, I'd go for something like this:
>
> 2017-02-07 Dominik Vogt <v...@linux.vnet.ibm.com>
> Rainer Orth <r...@cebitec.uni-bielefeld.de>
>
> * g++.dg/tls/thread_local-order2.C: Only xfail execution on
> *-*-solaris*.
>
> # HG changeset patch
> # Parent 031bb7a327cc984d387a8ae64e7c65d4b8793731
> Only xfail g++.dg/tls/thread_local-order2.C on Solaris
>
> diff --git a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
> b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
> --- a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
> +++ b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
> @@ -2,10 +2,11 @@
> // that isn't reverse order of construction. We need to move
> // __cxa_thread_atexit into glibc to get this right.
>
> -// { dg-do run { xfail *-*-* } }
> +// { dg-do run }
> // { dg-require-effective-target c++11 }
> // { dg-add-options tls }
> // { dg-require-effective-target tls_runtime }
> +// { dg-xfail-run-if "" { *-*-solaris* } }
>
> extern "C" void abort();
> extern "C" int printf (const char *, ...);
>
> This way one can easily add per-target PR references or explanations,
> e.g. for darwin10 or others should they come up.
>
> Tested on i386-pc-solaris2.12 and x86_64-pc-linux-gnu. Ok for mainline?
Ok.
I think that addresses most all known issues. I'll pre-appove any additional
targets people find as trivial. For example, if darwin10 doesn't pass, then
*-*-darwin10* would be fine to add if that fixes the issue. I don't happen to
have one that old to just test on.
