On Fri, Feb 03, 2017 at 11:43:53AM -0700, Jeff Law wrote:
> > + if (TREE_CODE (argtype) == POINTER_TYPE)
> > {
> > - if (POINTER_TYPE_P (argtype))
> > - argmax = build_all_ones_cst (argtype);
> > - else if (TYPE_UNSIGNED (argtype))
> > - argmax = TYPE_MAX_VALUE (argtype);
> > - else
> > - argmax = TYPE_MIN_VALUE (argtype);
> > + argmin = build_int_cst (pointer_sized_int_node, 0);
> > + argmax = build_all_ones_cst (pointer_sized_int_node);
> Curious why you didn't use the wide_int_to_tree API here. I'm not objecting
> to using build_XXX, it's more to help guide me when I need to make a choice
> between the APIs for building INTEGER_CST nodes.
For wide_int_to_tree I need to have some wide_int, which I have from the
VR_RANGE query, but not here. If I have an integer rather than wide-int,
then build_int_cst is the right API (I could use build_zero_cst, but
that in the end just checks if it is INTEGER_TYPE and calls build_int_cst
with 0 in that case).
> OK pending resolution of any conflicts with vla/flexible array changes from
> last night.
Thanks, I think there aren't any conflicts.
Jakub
