On Wed, 21 Sep 2011, David Miller wrote: > From: Hans-Peter Nilsson <h...@bitrange.com> > Date: Wed, 21 Sep 2011 21:27:08 -0400 (EDT) > > > While revisiting VIS, *please* consider fixing a big usability > > problem: the pack and aligndata builtins don't take GSR in > > account; it has unknown state and might be changed as a > > side-effect of a previous VIS insn (well, alignaddr). The > > affected builtins don't have dependencies to GSR or a means to > > set it besides in an asm; hardly usable at all. See PR48974. > > I know, see my posting from yesterday: > > -------------------- > Subject: [PATCH] Use TREE_READONLY on some sparc VIS builtins > > While fiddling around with the VIS intrinsic builtins I noticed that > none of them have TREE_READONLY set, so the resulting code can be > terrible. > > We can't currently do this for alignaddr and faligndata because we > don't model the way those instructions use the %gsr register.
Minor inconsistency spotted there: the same goes for the fpack insns but you now set TREE_READONLY for them. (Not claiming I caught all of them.) brgds, H-P
