On Fri, Jan 27, 2017 at 07:02:45AM -0800, Cesar Philippidis wrote:
> While experimenting with some new OpenACC benchmarks, I noticed that
> gfortran errors when the user explicitly marks loop induction variables
> as private. I applied this patch to gomp-4_0-branch to resolve that problem.
>
> Cesar
> 2017-01-26 Cesar Philippidis <ce...@codesourcery.com>
>
> gcc/fortran/
> * openmp.c (gfc_resolve_oacc_blocks): Populate list of private
> variables.
>
> gcc/testsuite/
> * gfortran.dg/goacc/implicitly-private.f90: New test.
>
>
> diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c
> index 61940d7..2782a8d 100644
> --- a/gcc/fortran/openmp.c
> +++ b/gcc/fortran/openmp.c
> @@ -5192,7 +5192,8 @@ gfc_resolve_oacc_blocks (gfc_code *code, gfc_namespace
> *ns)
> {
> fortran_omp_context ctx;
> oacc_function dims = OACC_FUNCTION_NONE;
> -
> + gfc_omp_namelist *n;
> +
> resolve_oacc_loop_blocks (code);
>
> ctx.code = code;
> @@ -5217,6 +5218,10 @@ gfc_resolve_oacc_blocks (gfc_code *code, gfc_namespace
> *ns)
> ctx.dims = dims;
> omp_current_ctx = &ctx;
>
> + if (code->ext.omp_clauses)
> + for (n = code->ext.omp_clauses->lists[OMP_LIST_PRIVATE]; n; n = n->next)
> + ctx.private_iterators->add (n->sym);
Do you really want to add to private_iterators even variables that aren't
iterators, just arbitrary private variable?
Jakub
