On Tue, Jan 24, 2017 at 10:09:23AM -0800, Carl E. Love wrote: > > Do we need a separate testcase to check for this? Or do those specific > > builtins need better testcases? Or was the bug obvious already?
[ ... ] > Once the bug for the ALTIVEC_BUILTIN_VEC_PACKS built-in was found, I > wrote a perl script to scan through the entire table looking for the > issue with any other built-in functions. I think we should have the compiler itself do this check, with flag_checking enabled or similar. It is too easy to get this wrong it seems :-( > Please let me know if you want me to go ahead with the adding the vec_packs() > test cases > to the patch or not. Again, not so sure about the vec_vgbbd test cases. If you have tests ready, then sure, add them please (in a separate patch is fine). Segher