> On Jan 16, 2017, at 4:24 PM, Segher Boessenkool <seg...@kernel.crashing.org>
> wrote:
>
> Hi Bill,
>
> A few comments:
>
> On Mon, Jan 16, 2017 at 12:12:22PM -0600, Bill Schmidt wrote:
>> * config/rs6000/rs6000-builtin.def (VRLWNM): New monomorphic
>> function entry.
>
> I had to look up if "monomorphic" is an existing word in this context.
> Unfortunately it is, sigh (it clashes hard with all the more common
> meanings).
Eh, "more common" if you are an algebra or biology bigot. :P
>
>> --- gcc/config/rs6000/altivec.h (revision 244498)
>> +++ gcc/config/rs6000/altivec.h (working copy)
>> @@ -168,6 +168,9 @@
>> #define vec_re __builtin_vec_re
>> #define vec_round __builtin_vec_round
>> #define vec_recipdiv __builtin_vec_recipdiv
>> +#define vec_rlmi __builtin_vec_rlmi
>> +#define vec_vrlnm __builtin_vec_rlnm
>> +#define vec_rlnm(a,b,c) (__builtin_vec_rlnm(a,(b<<8)|c))
>
> This needs parens around the arguments.
Oops, fixing.
>
>> +The result of @code{vec_rlmi} is obtained by rotating each element of
>> +the first argument vector left and inserting it under mask into the
>> +second argument vector.
>
> Did you swap first and second here?
No -- this is the way the vec_rlmi interface is defined in the appendix.
Thanks for the review!
Bill
>
> Okay for trunk with those points addressed. Thanks!
>
>
> Segher
>
