On 16 January 2017 at 10:43, Richard Biener <rguent...@suse.de> wrote:
> On Mon, 16 Jan 2017, Christophe Lyon wrote:
>
>> On 13 January 2017 at 12:16, Bin.Cheng <amker.ch...@gmail.com> wrote:
>> > On Fri, Jan 13, 2017 at 9:46 AM, Richard Biener <rguent...@suse.de> wrote:
>> >>
>> >> The following is an attempt to change those testcases to be less dependent
>> >> on previous passes. The original motivation of the testcases seems to be
>> >> testing SCEV capabilities and in turn IVOPTs decisions, thus the testcases
>> >> are changed to check the IVO dump, use the GIMPLE FE feeding the loop
>> >> pipeline directly and skip lowering/store-motion we meanwhile do to
>> >> the testcase.
>> >>
>> >> To avoid some existing issue with CFG construction after GIMPLE parsing
>> >> we need to be able to add GIMPLE_NOPs which the patch enables to generate
>> >> from empty stmts (previously those resulted in parse errors).
>> >>
>> >> Tested the testcases on x86_64 with {,-m32} sofar I'll appreciate
>> >> testing on more targets.
>> > I checked aarch64-elf/aarch64-linux with default configuration, all
>> > passed with this change.
>> >
>>
>> For me, the testcases don't compile with this patch:
>> gcc.dg/tree-ssa/scev-3.c: In function 'f':
>> gcc.dg/tree-ssa/scev-3.c:30:3: error: '__MEM' undeclared (first use in
>> this function)
>> gcc.dg/tree-ssa/scev-3.c:30:3: note: each undeclared identifier is
>> reported only once for each function it appears in
>> gcc.dg/tree-ssa/scev-3.c:30:9: error: expected '=' before '<' token
>>
>> Did I misapply the patch?
>
> You need
>
> 2017-01-12 Richard Biener <rguent...@suse.de>
>
> * gimple-parser.c (c_parser_gimple_postfix_expression): Parse
> __MEM.
>
> in c/ChangeLog for it to work.
>
Indeed, thanks.
With it, I confirm the tests now pass on aarch64 and arm.
Thanks
Christophe
> Richard.
>
>> > Thanks,
>> > bin
>> >>
>> >> Full bootstrap / regtest running on x86_64-unknown-linux-gnu.
>> >>
>> >> Richard.
>> >>
>> >
>> >> - }
>> >> }
>> >>
>> >> -/* { dg-final { scan-tree-dump-times "&a" 1 "optimized" } } */
>> >> +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */
>>
>>
>
> --
> Richard Biener <rguent...@suse.de>
> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB
> 21284 (AG Nuernberg)
