Hi Richard, Thanks for the review! Replies/questions inline.
On Fri, Jan 13, 2017 at 2:28 PM, Richard Biener <richard.guent...@gmail.com> wrote: > On Thu, Jan 12, 2017 at 3:55 PM, Pekka Jääskeläinen <pe...@parmance.com> > wrote: >> Hi, >> >> A gentle ping... > > diff --git a/gcc/configure.ac b/gcc/configure.ac > index 140b9f9..06941c5 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -996,6 +996,11 @@ if test x"$enable_hsa" = x1 ; then > [Define this to enable support for generating HSAIL.]) > fi > > +if echo "$enable_languages" | grep "brig" > /dev/null; then > + AC_DEFINE(ENABLE_BRIG_FE, 1, > + [Define this to enable the BRIG (HSAIL) frontend.]) > +fi > + > > this looks odd and I'd have expected this to be solely controlled via > --enable-languages at configure time? Yes, it is. This AC_DEFINE just adds an autoconf variable ENABLE_BRIG_FE using which I guard unnecessary inclusion of the brig-builtins.def in builtins.def in case BRIG FE is disabled. > @@ -1366,6 +1369,11 @@ assembler assembler-with-cpp > ada > f77 f77-cpp-input f95 f95-cpp-input > go > +<<<<<<< HEAD > +java > +brig > +======= > +>>>>>>> gcc-master > @end smallexample > > @item -x none > > unmerged hunk (java is gone). Cleaned. > diff --git a/include/hsa-interface.h b/include/hsa-interface.h > new file mode 100644 > index 0000000..6765751 > --- /dev/null > +++ b/include/hsa-interface.h > @@ -0,0 +1,630 @@ > +/* HSA runtime API 1.0.1 representation description. > + Copyright (C) 2016 Free Software Foundation, Inc. > + > ... > > this looks like a sub/superset of libgomp/plugin/hsa.h, please work on > retaining only one version. Merged. > Did you check whether libhsail-rt builds for all GCC targets? If not > you probably want to add > a list where to disable the frontend and its runtime (see go / libgo > for an example in the > toplevel configure.ac). I have tested only x86 of the GCC upstream targets so far. Libgo seems to black list known broken ones with a separate --enable-libgo switch to force enable. However, BRIG FE and libhsail-rt are disabled by default. Should I still add a separate switch to force enable BRIG and enable it by default for x86? Or should I force disable it even when enabled with --enable-languages when building for an untested target? Thanks, Pekka
