Hi,
In addition to Uroš's inputs:
> diff --git a/gcc/config/i386/avx512vpopcntdqintrin.h
> b/gcc/config/i386/avx512vpopcntdqintrin.h
> new file mode 100644
> index 0000000..28305f6
> --- /dev/null
> +++ b/gcc/config/i386/avx512vpopcntdqintrin.h
> @@ -0,0 +1,90 @@
> +/* Copyright (C) 2016 Free Software Foundation, Inc.
Pls, fix year.

Pattern should perfectly fit into subst infra.

On 27 Dec 14:59, Uros Bizjak wrote:
> On Tue, Dec 27, 2016 at 2:47 PM, Uros Bizjak <ubiz...@gmail.com> wrote:
> > On Tue, Dec 27, 2016 at 2:40 PM, Andrew Senkevich
> > <andrew.n.senkev...@gmail.com> wrote:
> >> 2016-12-27 16:35 GMT+03:00 Uros Bizjak <ubiz...@gmail.com>:
> >>> Hello!
> >>>
> >>>> this patch enables AVX512 VPOPCNTD/VPOPCNTQ instructions recently
> >>>> added in Instruction Set Extensions
> >>>> (https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf).
> >>>
> >>> @@ -265,6 +268,9 @@
> >>>  (define_mode_iterator VF_512
> >>>    [V16SF V8DF])
> >>>
> >>> +(define_mode_iterator VI_AVX512F
> >>> +  [V16SI V8DI])
> >>>
> >>> Please name this iterator VI_512.
> >>
> >> But there are already VI_512 :)
> >>
> >> ;; All 512bit vector integer modes
> >> (define_mode_iterator VI_512
> >>   [(V64QI "TARGET_AVX512BW")
> >>    (V32HI "TARGET_AVX512BW")
> >>    V16SI V8DI])
> >
> > Eh, this one is duplicate of VI_AVX512BW and should be removed.
>
> Actually, you should use existing VI48_512 mode iterator.
>
> Uros.

--
Thanks, K

Reply via email to