On 09.01.17 18:36, Jakub Jelinek wrote:
On Mon, Jan 09, 2017 at 06:25:05PM +0100, Andreas Tobler wrote:
On 09.01.17 12:25, Jakub Jelinek wrote:
On Mon, Jan 09, 2017 at 11:53:38AM +0100, Richard Biener wrote:
Ok, attached the part I bootstrapped successfully on amd64-*-freebsd12 and
aarch64-*-freebsd12. From the amd64 run you'll find some test results at the
usual place. The aarch64 run takes some more time.

I hope I got it right this time :)
What do you think?

Looks good to me with the added comment to dwarf2out_late_global_decl
exchanged to the one on trunk.

The formatting is completely wrong.
Lines indented e.g. by 7 spaces (or tab + 1/3 space(s)),
/* comment inside of { block starting in the same column as {
(should be 2 columns to the right), && ! not aligned below VAR_P,
or indenting by 3 columns instead of 2.

Hehe, yep. This time done with emacs ;)

Here the hopefully final patch with proper ChangeLog and formatting fixed.

Ok to apply?

Formatting LGTM, so I think Richard's approval applies now.

Thanks a lot!

Committed as 244240.

Andreas

Reply via email to