On Tue, Dec 20, 2016 at 3:42 PM, Andre Vehreschild <ve...@gmx.de> wrote: > Hi all, > >> I think you should use build_zero_cst(size_type_node) instead of >> size_zero_node as size_zero_node is of type sizetype which is not the >> same as size_type_node. Otherwise looks good. > > In the software design classes I took this was called a design error: Not > choosing sufficiently different names for different artifacts. It was > considered a beginner's error.
Yeah, sizetype vs. size_type_node is confusing, to say the least.. > So now I have to repeat myself 16 times only to work around this b***. Nothing > that will improve gfortran's maintainability. > > Second version of the changes needed for caf attached. Bootstrapped and > regtested fine besides prior known > > FAIL: gfortran.dg/allocate_deferred_char_scalar_1.f03 -O1 (test for excess > errors) > > on x86_64-linux/f23. Ok, looks good. -- Janne Blomqvist
