On 12/09/2016 08:32 PM, David Malcolm wrote:
Thanks. Unfortunately, applying the "locate_file" patch https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01186.html would now introduce a regression in a recently-added test case:
The problem is that this DejaGnu test case uses -fself-test, and doesn't provide any arguments. With the locate_file patch, we need to pass the path to $(srcdir)/testsuite/selftests as an argument to -fself -test, and it's not clear to me how to do that sanely in a DejaGnu test case; if I pass in a dummy value (like for pr71591.c), then the selftests that use locate_file fail.
I think this part of the selftest framework (how to locate files and tests) is possibly going to need some rethinking. But for now, I'm ok with just adding dg-skip-if *-*-* to the problematic testcase, with a comment describing the situation.
Bernd