Hi Andrew,
Approved, but ...
> +/* Return true if a load instruction (CONSUMER) uses the same address
> + as a store instruction (PRODUCER). This function is used to avoid
> + st/ld address hazard in ARC700 cores. */
Missing space after dot.
> + /* Peel the producer and the consumer for the address. */
Likewise.
> + out_set = single_set (producer);
> + if (out_set)
> + {
> + out_addr = SET_DEST (out_set);
> + if (!out_addr)
> + return false;
> + if (GET_CODE (out_addr) == ZERO_EXTEND
> + || GET_CODE (out_addr) == SIGN_EXTEND)
> + out_addr = XEXP (out_addr, 0);
> +
> + if (!MEM_P(out_addr))
Space between macro and parenthesis.
> + return false;
> +
> + in_set = single_set (consumer);
> + if (in_set)
> + {
> + in_addr = SET_SRC (in_set);
> + if (!in_addr)
> + return false;
> + if (GET_CODE (in_addr) == ZERO_EXTEND
> + || GET_CODE (in_addr) == SIGN_EXTEND)
> + in_addr = XEXP (in_addr, 0);
> +
> + if (!MEM_P(in_addr))
Likewise.
> + return false;
> + /* Get rid of the MEM() and check if the addresses are
> + equivalent. */
Space, space after dot.
> + in_addr = XEXP (in_addr, 0);
> + out_addr = XEXP (out_addr, 0);
> +
> + return exp_equiv_p (in_addr, out_addr, 0, true);
> + }
> + }
> + return false;
> +}
> +
> /* The same functionality as arc_hazard. It is called in machine
> reorg before any other optimization. Hence, the NOP size is taken
> into account when doing branch shortening. */
> @@ -6501,6 +6553,29 @@ workaround_arc_anomaly (void)
> emit_insn_before (gen_nopv (), succ0);
> }
> }
> +
> + if (TARGET_ARC700)
> + {
> + rtx_insn *succ1;
> +
> + for (insn = get_insns (); insn; insn = NEXT_INSN (insn))
> + {
> + succ0 = next_real_insn(insn);
Space between function name and parenthesis.
> + if (arc_store_addr_hazard_p (insn, succ0))
> + {
> + emit_insn_after (gen_nopv (), insn);
> + emit_insn_after (gen_nopv (), insn);
> + continue;
> + }
> +
> + /* Avoid adding nops if the instruction between the ST and LD is
> + a call or jump. */
> + succ1 = next_real_insn(succ0);
Likewise.
> + if (succ0 && !JUMP_P (succ0) && !CALL_P (succ0)
> + && arc_store_addr_hazard_p (insn, succ1))
> + emit_insn_after (gen_nopv (), insn);
> + }
> + }
> }
Best,
Claudiu
