On 11/23/2016 10:09 AM, Richard Sandiford wrote:
Richard Biener <richard.guent...@gmail.com> writes:
On Tue, Nov 22, 2016 at 10:00 AM, Richard Sandiford
<richard.sandif...@arm.com> wrote:
This loop:
/* Make sure the tail invocation of this function does not refer
to local variables. */
FOR_EACH_LOCAL_DECL (cfun, idx, var)
{
if (TREE_CODE (var) != PARM_DECL
&& auto_var_in_fn_p (var, cfun->decl)
&& (ref_maybe_used_by_stmt_p (call, var)
|| call_may_clobber_ref_p (call, var)))
return;
}
triggered even for local variables that are passed by value.
This meant that we didn't allow local aggregates to be passed
to a sibling call but did (for example) allow global aggregates
to be passed.
I think the loop is really checking for indirect references,
so should be able to skip any variables that never have their
address taken.
Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?
Ok. We've had various correctness issues in this part in the past so
I'd prefer if you can rewrite your dg-do compile tests to dg-do run ones
that verify the code works correctly. I suggest to use a dg-additional-sources
with a separate TU for the execution driver.
OK, how's this? Tested on aarch64-linux-gnu and x86_64-linux-gnu.
Thanks,
Richard
gcc/testsuite/
* gcc.dg/tree-ssa/tailcall-7-run.c: New test.
* gcc.dg/tree-ssa/tailcall-8-run.c: Likewise.
Works for me.
jeff
