On Wed, Nov 23, 2016 at 2:54 PM, Bin Cheng <bin.ch...@arm.com> wrote: > Hi, > This is actually the review suggestion for patch > @https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02341.html, but I forgot to > incorporate it when committing that patch. Here comes this one doing that, > as well as adding a missing convert keyword. Toolchain built successfully, > is it OK?
As said you _do_ need the outermost (convert ...) on the (max .. and (min ... expressions given @1 may not be of type 'type'. > Thanks, > bin > > 2016-11-23 Bin Cheng <bin.ch...@arm.com> > > * match.pd: Refine type conversion in result expressions for below > pattern: > (cond (cmp (convert1? x) c1) (convert2? x) c2) -> (minmax (x c)).
