Hi Dominique, >> the attached patch fixes an ice-on-valid problem, simply by removing an >> assert. ... > > I have several instances in my test suite showing that the proposed patch > removes the ICE but generates wrong code: > > pr42359, second test, => ICE on another place > pr54613, sixth and eighth tests,
thanks for the comments, those cases are closely related. I previously assumed that the test case for this PR would be legal, but by now I think that's wrong. The test case should be rejected, and we already have checking mechanisms for this (see resolve_fl_variable), but apparently they are not working. My current suspicion is that 'gfc_is_constant_expr' has a bug, because it claims the call to the function 'get_i' to be a constant expression. This is not true, because get_i() can not be reduced to a compile-time constant. In any case the patch I proposed is wrong and the assert should stay. Cheers, Janus
