2016-11-13 0:57 GMT+01:00 Steve Kargl <s...@troutmask.apl.washington.edu>: > On Sat, Nov 12, 2016 at 09:13:26PM +0100, Janus Weil wrote: >> >> this patch fixes an ICE on invalid code involving class component >> declarations. The ICE is avoided by moving forward the error check >> from resolution to parsing stage. For class components this is >> possible, because the attributes have to be specified in the same line >> (in contrast to class variables, where the attributes can be specified >> in multiple statements, so that checking can only be done during >> resolution). >> >> Note that this fixes only the original example, but not comment 2 >> (which is a different issue). >> >> Regtests cleanly on x86_64-linux-gnu. Ok for trunk? >> > > Looks good to me. Thanks.
Thanks! Committed as r242351. Cheers, Janus
