On Thu, Nov 10, 2016 at 07:27:00PM +0300, Andrew Senkevich wrote:
> Hi,
>
> this patch enabled AVX512_4FMAPS and AVX512_4VNNIW instructions.
>
> It requires additional patch for register allocator from Vladimir
> Makarov to be committed before.
Your MUA ate tabs (and in the ChangeLog you're using spaces instead of
tabs), can you repost as attachment or configure your MUA not to do this?
Just a couple of random nits follow:
> * gcc.target/i386/sse-12.c: Add -mavx5124fmaddps.
This mentions an option that doesn't exist, is that s/dd// ?
> * gcc.target/i386/sse-13.c: Ditto.
> @@ -399,6 +403,13 @@ ix86_handle_option (struct gcc_options *opts,
> {
> opts->x_ix86_isa_flags &= ~OPTION_MASK_ISA_AVX512F_UNSET;
> opts->x_ix86_isa_flags_explicit |= OPTION_MASK_ISA_AVX512F_UNSET;
> +
> + //turn off additional isa flags
Comments start with capital letter, end with ., there should be space
between // and T, better use /* ... */ style comment to match other
comments in the file.
> + opts->x_ix86_isa_flags2 &= ~OPTION_MASK_ISA_AVX5124FMAPS_UNSET;
> + opts->x_ix86_isa_flags2_explicit |=
> OPTION_MASK_ISA_AVX5124FMAPS_UNSET;
> + opts->x_ix86_isa_flags2 &= ~OPTION_MASK_ISA_AVX5124VNNIW_UNSET;
> + opts->x_ix86_isa_flags2_explicit |=
> OPTION_MASK_ISA_AVX5124VNNIW_UNSET;
> +
> }
The formatting looks very weird.
Jakub
