Hi! On Wed, Nov 09, 2016 at 01:24:22PM +0100, Jakub Jelinek wrote: > The following patch is a WIP on P0217R3 - decomposition declarations. > It contains various FIXMEs, Jason, do you think you could finish it up?
Some more comments: Invalid? code like int arr[2]; extern int x, y; auto [ x, y ] = arr; depends on PR78217 fix, so I haven't added testsuite coverage for that yet. Nor for decomp at namespace scope. There is no coverage for bitfields either. And the testsuite coverage surely needs to have some verification of the exact types and cv quals of the individual decls, the tests only cover their addresses. As implemented in the patch, those decls with DECL_VALUE_EXPRs have non-reference type always, not sure if it is ok or not. Jakub