> You need more than that, e.g. reg_nonzero_bits_for_combine looks at the > nonzero_bits field no matter what else.
Right, this one is sticky, although you can invalidate it globally by means of nonzero_sign_valid AFAICS. > I didn't have the heart to look into this testcase breakage; the > save/restore thing would make this already way over-complex code a lot > more complex still, so I made a safer change instead. I agree that the save/restore approach is probably overkill but, on the other hand, your change only papers over the issue so a big ??? comment is in order if it goes in. I'd still think that we should try to invalidate if possible. -- Eric Botcazou
