On Nov 1, 2016, at 8:46 AM, Tamar Christina <tamar.christ...@arm.com> wrote:
> 
> A glibc update recently broke this test by adding a CPP
> macro that uses the ## string function which traditional-cpp
> does not support.
> The change in glibc that made the test fail is from
> 6962682ffe5e5f0373047a0b894fee7a774be254.
> 
> This fixes (PR78136) by changing the test to use a local
> include file instead of one from glibc.
> The intention of the test is to test that traditional-cpp does
> not expand values inside <> blocks of #includes.
> As such the include has to be included via <> syntax. To do this
> the .exp has been modified to add the test directory to the
> Include search path.
> 
> Ran regression tests on aarch64-none-linux-gnu.
> 
> Ok for trunk?
Ok.

Can you remove the comment: Newlib uses ## when including stdlib.h as of 
2007-09-07.  while you are at it?  I think it doesn't make any sense post the 
change unless one reads history.

> 2016-10-31  Tamar Christina  <tamar.christ...@arm.com>
> 
>       PR testsuite/78136
>       * gcc.dg/cpp/trad/trad.exp
>       (dg-runtest): Added $srcdir/$subdir/ to Include dirs.
>       * gcc.dg/cpp/trad/include.c: Use local header 
> file.<pr78136-fix-tradition-cpp>

Reply via email to