Clearly a desired fallthru in cr16_pritn_operand handling of 'g'.

Shortly thereafter there's another fallthru, but AFAICT it shouldn't ever happen. I've added a gcc_unreachable in that case.

Installing on the trunk.


Jeff
commit 24e65f049fd63325296b4172fc175633a2cde8d0
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Oct 26 16:27:44 2016 +0000

        * config/cr16/cr16.c (cr16_print_operand): Add missing fallthru
        comment.  Add gcc_unreachable for path that should never happen.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@241584 
138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index bf5080a..ce2693b 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,8 @@
 2016-10-26  Jeff Law  <l...@redhat.com>
 
+       * config/cr16/cr16.c (cr16_print_operand): Add missing fallthru
+       comment.  Add gcc_unreachable for path that should never happen.
+
        * config/epiphany/epiphany.c (epiphany_print_operand): Adjust
        fallthru comment.
 
diff --git a/gcc/config/cr16/cr16.c b/gcc/config/cr16/cr16.c
index 530ccba..cc24fa5 100644
--- a/gcc/config/cr16/cr16.c
+++ b/gcc/config/cr16/cr16.c
@@ -1476,6 +1476,7 @@ cr16_print_operand (FILE * file, rtx x, int code)
     case 'g':
       /* 'g' is used for implicit mem: dereference.  */
       ptr_dereference = 1;
+      /* FALLTHRU */
     case 'f':
     case 0:
       /* default.  */
@@ -1528,6 +1529,7 @@ cr16_print_operand (FILE * file, rtx x, int code)
          cr16_print_operand_address (file, VOIDmode, x);
          return;
        }
+      gcc_unreachable ();
     default:
       output_operand_lossage ("invalid %%xn code");
     }

Reply via email to