Hi!
On Wed, 5 Oct 2016 16:36:01 +0200, Bernd Schmidt <bschm...@redhat.com> wrote:
> On 10/05/2016 04:14 PM, David Malcolm wrote:
> > Thanks. I'm not able to formally approve these changes, but FWIW these
> > patches look good to me (assuming usual testing).
>
> LGTM too, so OK.
Without changes, committed to trunk in r241043 and r241044:
commit 441751466e69eaf8d8da7c0d388055509b35bc63
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed Oct 12 13:09:06 2016 +0000
In gcc/Makefile.in, factor out SELFTEST_FLAGS
gcc/
* Makefile.in (SELFTEST_FLAGS): New variable.
(s-selftest, selftest-gdb, selftest-valgrind): Use it.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@241043
138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/ChangeLog | 3 +++
gcc/Makefile.in | 11 ++++++++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git gcc/ChangeLog gcc/ChangeLog
index e57438e..003316f 100644
--- gcc/ChangeLog
+++ gcc/ChangeLog
@@ -1,5 +1,8 @@
2016-10-12 Thomas Schwinge <tho...@codesourcery.com>
+ * Makefile.in (SELFTEST_FLAGS): New variable.
+ (s-selftest, selftest-gdb, selftest-valgrind): Use it.
+
* vmsdbgout.c (vmsdbg_debug_hooks): Add filename parameter to
early_finish hook.
diff --git gcc/Makefile.in gcc/Makefile.in
index 2914605..02d0c45 100644
--- gcc/Makefile.in
+++ gcc/Makefile.in
@@ -1877,6 +1877,10 @@ endif
# This does the things that can't be done on the host machine.
rest.cross: specs
+# GCC's selftests.
+# Specify a dummy input file to placate the driver.
+SELFTEST_FLAGS = -x c /dev/null -S -fself-test
+
# Run the selftests during the build once we have a driver and a cc1,
# so that self-test failures are caught as early as possible.
# Use "s-selftest" to ensure that we only run the selftests if the
@@ -1884,18 +1888,19 @@ rest.cross: specs
.PHONY: selftest
selftest: s-selftest
s-selftest: $(GCC_PASSES) cc1$(exeext) stmp-int-hdrs
- $(GCC_FOR_TARGET) -xc -S -c /dev/null -fself-test
+ $(GCC_FOR_TARGET) $(SELFTEST_FLAGS)
$(STAMP) $@
# Convenience method for running selftests under gdb:
.PHONY: selftest-gdb
selftest-gdb: $(GCC_PASSES) cc1$(exeext) stmp-int-hdrs
- $(GCC_FOR_TARGET) -xc -S -c /dev/null -fself-test -wrapper gdb,--args
+ $(GCC_FOR_TARGET) $(SELFTEST_FLAGS) \
+ -wrapper gdb,--args
# Convenience method for running selftests under valgrind:
.PHONY: selftest-valgrind
selftest-valgrind: $(GCC_PASSES) cc1$(exeext) stmp-int-hdrs
- $(GCC_FOR_TARGET) -xc -S -c /dev/null -fself-test \
+ $(GCC_FOR_TARGET) $(SELFTEST_FLAGS) \
-wrapper valgrind,--leak-check=full
# Recompile all the language-independent object files.
commit c2d86129ef8141bb214958ca90be15fbeb42f4b1
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed Oct 12 13:09:17 2016 +0000
Make GCC selftests work for *-wrs-vxworks-* targets
gcc/
* Makefile.in (SELFTEST_FLAGS): Add -nostdinc.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@241044
138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/ChangeLog | 2 ++
gcc/Makefile.in | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git gcc/ChangeLog gcc/ChangeLog
index 003316f..d6880d9 100644
--- gcc/ChangeLog
+++ gcc/ChangeLog
@@ -1,5 +1,7 @@
2016-10-12 Thomas Schwinge <tho...@codesourcery.com>
+ * Makefile.in (SELFTEST_FLAGS): Add -nostdinc.
+
* Makefile.in (SELFTEST_FLAGS): New variable.
(s-selftest, selftest-gdb, selftest-valgrind): Use it.
diff --git gcc/Makefile.in gcc/Makefile.in
index 02d0c45..f1ff782 100644
--- gcc/Makefile.in
+++ gcc/Makefile.in
@@ -1879,7 +1879,9 @@ rest.cross: specs
# GCC's selftests.
# Specify a dummy input file to placate the driver.
-SELFTEST_FLAGS = -x c /dev/null -S -fself-test
+# Specify -nostdinc to work around missing WIND_BASE environment variable
+# required for *-wrs-vxworks-* targets.
+SELFTEST_FLAGS = -nostdinc -x c /dev/null -S -fself-test
# Run the selftests during the build once we have a driver and a cc1,
# so that self-test failures are caught as early as possible.
Grüße
Thomas
