On Sun, Sep 4, 2011 at 11:00 AM, Tom de Vries <vr...@codesourcery.com> wrote:
> Hi,
>
> this patch fixes PR50251, which was caused by r178353.
>
> The patch was bootstrapped and reg-tested on i686 and x86_64.
> On i686, the test-cases reported failing in PR50251 pass again.
>
> The patch selects the DRAP type stack realignment method in case a 
> stack_restore
> is used. If that is not done, the presence of the stack_restore at reload 
> leaves
> FRAME_POINTER without an elimination rule for i386 port.
>
> OK for trunk?

Shouldn't we eventually simply set cfun->calls_alloca when expanding either
stack save or restore?  Similar to how it is set from
allocate_dynamic_stack_space?
I'm not sure we encountered the dead stack save/restore pair before
this new folding,
so, just to make other targets not confused about them as well?

Thanks,
Richard.

> Thanks,
> - Tom
>
>
> 2011-09-03  Tom de Vries  <t...@codesourcery.com>
>
>            * explow.c (emit_stack_restore): Set crtl->need_drap if
>            stack_restore is emitted.
>

Reply via email to