On Mon, Sep 26, 2016 at 03:26:28PM +0200, Jakub Jelinek wrote: > On Mon, Sep 26, 2016 at 03:22:08PM +0200, Marek Polacek wrote: > > Before I spend time on this, I wanted to check if you consider this a good > > idea. Since c-common.c has grown a lot and is quite large now, I think we > > might split it into c-warn.c, where various warning routines would go. > > What do > > you think? > > Perhaps c-attribs.c for the attribute handling stuff too?
Yeah. The way I envision c-common.c is to contain shared c-family routines such as c_common_type_for_*, c_save_expr, max_align_t_align, and similar, but the warnings/diagnostics might use their own file. Marek