On Mon, Sep 26, 2016 at 11:21 AM, Robin Dapp <rd...@linux.vnet.ibm.com> wrote: >> Comments added. Bootstrap and test, is it reasonable? > > This introduces an ICE on s390x with a Fortran testcase, because > of an assertion failure in tree_to_uhwi (DR_STEP (dr_a.dr)) for > DR_STEP (dr_a.dr) = -8(OVF). > > The attached patch fixes this by introducing an additional > tree_fits_uhwi_p(). > > ok to commit?
no, this disables handling of negative step. I think it should check for tree_fits_shwi_p () instead and adjust the code to do unsigned HOST_WIDE_INT abs_step = absu_hwi (tree_to_shwi (DR_STEP (dr_a.dr))); Richard. > Regards > Robin > > -- > > gcc/ChangeLog: > > 2016-09-26 Robin Dapp <rd...@linux.vnet.ibm.com> > > * tree-vect-loop-manip.c (create_intersect_range_checks_index): > Add tree_fits_uhwi_p check.
