On Mon, 26 Sep 2016, Thomas Preudhomme wrote: > > > On 26/09/16 10:15, Richard Biener wrote: > > On Thu, 22 Sep 2016, Thomas Preudhomme wrote: > > > > > Hi, > > > > > > This patch is part of a patch series to add support for ARMv8-M[1] to GCC. > > > This specific patch moves memory model declarations in memmodel.h. > > > > > > Currently, is_mm_* memory model related functions are declared in tree.h > > > which > > > prevents using them in constraints machine description files. This patch > > > move > > > this functions into a new memmodel.h header to allow such a thing and > > > update > > > all users of this function to include the new header. > > > > Ok. I wonder whether we can move the memmodel stuff from coretypes > > as well then? > > It's not needed for using what's in there in constraints.md but would be good > for consistency I think. Do you want me to add it to the patch or make a > separate one and commit this one?
If it's trivial to include then go with this patch, if it requires work then as followup is fine with me. Thanks, Richard. > > > > Thanks, > > Richard. > > Best regards, > > Thomas > > > > > > ChangeLog entries are as follows: > > > > > > *** gcc/ChangeLog *** > > > > > > 2016-04-20 Thomas Preud'homme <thomas.preudho...@arm.com> > > > > > > * tree.h (memmodel_from_int, memmodel_base, is_mm_relaxed, > > > is_mm_consume, is_mm_acquire, is_mm_release, is_mm_acq_rel, > > > is_mm_seq_cst, is_mm_sync): Move to ... > > > * memmodel.h: This. New file. > > > * builtins.c: Include memmodel.h. > > > * optabs.c: Likewise. > > > * tsan.c: Likewise. > > > * config/aarch64/aarch64.c: Likewise. > > > * config/alpha/alpha.c: Likewise. > > > * config/arm/arm.c: Likewise. > > > * config/i386/i386.c: Likewise. > > > * config/ia64/ia64.c: Likewise. > > > * config/mips/mips.c: Likewise. > > > * config/rs6000/rs6000.c: Likewise. > > > * config/sparc/sparc.c: Likewise. > > > * genconditions.c: Include memmodel.h in generated file. > > > * genemit.c: Likewise. > > > * genoutput.c: Likewise. > > > * genpeep.c: Likewise. > > > * genpreds.c: Likewise. > > > * genrecog.c: Likewise. > > > > > > > > > *** gcc/c-family/ChangeLog *** > > > > > > 2016-04-20 Thomas Preud'homme <thomas.preudho...@arm.com> > > > > > > * c-common.c: Include memmodel.h. > > > > > > > > > Is this ok for trunk? > > > > > > Best regards, > > > > > > Thomas > > > > > > > -- Richard Biener <rguent...@suse.de> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
