On Mon, Sep 26, 2016 at 11:56:01AM +0200, Martin Liška wrote:
> @item -fsanitize=kernel-address
> @opindex fsanitize=kernel-address
> @@ -10169,17 +10170,19 @@ details. The run-time behavior can be influenced
> using the @env{TSAN_OPTIONS}
> environment variable; see
> @url{https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags} for a
> list of
> supported options.
> +The option can't be combined with @option{-fsanitize=address}
> +and @option{-fsanitize=leak}.
Shouldn't that be or instead of and, or and/or ?
> - flags |= sanitizer_opts[i].flag;
> + {
> + /* Do not enable -fsanitize-recover=unreachable and
> + -fsanitize-recover=return if -fsanitize-recover=undefined
> + is selected. */
> + if (sanitizer_opts[i].flag == SANITIZE_UNDEFINED)
> + flags |= SANITIZE_UNDEFINED
> + & ~(SANITIZE_UNREACHABLE | SANITIZE_RETURN);
The formatting looks wrong. Either it should be
flags |= (SANITIZE_UNDEFINED
& ~(SANITIZE_UNREACHABLE | SANITIZE_RETURN));
or at least
flags |= SANITIZE_UNDEFINED
& ~(SANITIZE_UNREACHABLE | SANITIZE_RETURN);
Ok with those nits fixed.
Jakub
