On Fri, Sep 23, 2016 at 10:51 AM, Martin Liška <mli...@suse.cz> wrote:
> On 09/22/2016 03:07 PM, David Edelsohn wrote:
>> @@ -2222,13 +2221,11 @@ sem_variable::merge (sem_item *alias_item)
>> }
>>
>> /* We can not merge if address comparsion metters. */
>> - if (original_address_matters && alias_address_matters
>> - && flag_merge_constants < 2)
>> + if (alias_address_matters && flag_merge_constants < 2)
>> {
>> if (dump_file)
>> fprintf (dump_file,
>> - "Not unifying; "
>> - "adress of original and alias may be compared.\n\n");
>> + "Not unifying; adress of original may be compared.\n\n");
>> ^^^ address not adress
>> return false;
>> }
>>
>> The dump file message contains a typo: address not adress.
>>
>> +/* { dg-final { scan-ipa-dump "Not unifying; adress of original may
>> be compared." "icf" } } */
>>
>> Similarly, the testcase needs to be updated to match.
>>
>> Thanks, David
>>
>
> Thank you David for the nit, I've installed patch for that as r240399.
> I've also grepped the source code for 'adress' and I found another
> places where we have the typo.
>
> Is the attached patch ready to be installed?
Ok, but the classpath ones are imported from upstream (and is going to
be removed anyway), so please omit those.
Richard.
> Thanks,
> Martin
