> > > > I also like a new param better as it avoids a new magic constant and > > > > makes playing with > > > > it easier (your patch removes the ability to do statistics like you did > > > > via the > > > > early-inlining-insns parameter by forcing it to two). > > > > > > Hmm, you are right that you do not know if this particular function will > > > get > > > profile (forgot about that). Still, please use two params - it is more > > > consistent with what we have now and we may make it profile specific in > > > future.. > > > > > > Honza > > > > > > > > Thanks, > > > > Richard. > > > > A new patch for trunk is attached. > > > > Regards, > > Yuan, Pengfei > > > > > > 2016-09-16 Yuan Pengfei <y...@pku.edu.cn> > > > > * doc/invoke.texi (--param early-inlining-insns-feedback): New. > > * ipa-inline.c (want_early_inline_function_p): Use > > PARAM_EARLY_INLINING_INSNS_FEEDBACK when FDO is enabled. > > * params.def (PARAM_EARLY_INLINING_INSNS_FEEDBACK): Define. > > (PARAM_EARLY_INLINING_INSNS): Change help string accordingly. > > OK, > thanks > > Honza
Do I have to sign an FSF copyright assignment to get this patch applied? Regards, Yuan, Pengfei
