On Thu, Sep 15, 2016 at 10:28:19AM +0200, Richard Biener wrote:
> On Thu, Sep 15, 2016 at 6:31 AM, Trevor Saunders <tbsau...@tbsaunde.org>
> wrote:
> > On Thu, Sep 15, 2016 at 01:04:04PM +0900, Kaz Kojima wrote:
> >> tbsaunde+...@tbsaunde.org wrote:
> >> > @@ -2201,8 +2201,7 @@ fix_crossing_unconditional_branches (void)
> >> > {
> >> > if (!BARRIER_P (cur_insn))
> >> > BLOCK_FOR_INSN (cur_insn) = cur_bb;
> >> > - if (JUMP_P (cur_insn))
> >> > - jump_insn = cur_insn;
> >> > + jump_insn = dyn_cast<rtx_jump_insn *> (cur_insn);
> >> > }
> >>
> >> This hunk results several new failures for tree-profile tests on SH.
> >> If the line "if (JUMP_P (cur_insn))" is restored, those failures
> >> go away.
> >
> > That's interesting because dyn_cast should include that check. What is
> > the error?
>
> maybe jump_insn is non-NULL before? in which case you set it to NULL
> if ! JUMP_P while before we didn't.
Oh wow, I missed that this assignment was in a loop not an iff :(
makes sense now and easy enough to fix up.
Trev
>
> Richard.
>
> > Thanks!
> >
> > Trev
> >
> >>
> >> Regards,
> >> kaz
