On Mon, Sep 12, 2016 at 09:53:52PM +0000, Joseph Myers wrote:
> On Sat, 10 Sep 2016, Marek Polacek wrote:
>
> > A minor cleanup. First, FLAG is a really bad name for a parameter, and
> > second,
> > using two vars for the same thing is redundant (we never modify any of
> > them).
> > Also some bad formatting.
> >
> > Bootstrap/regtest on x86_64-linux running. Ok for trunk?
>
> OK. If changing this argument it would seem natural to make it a bool
Thanks.
> (and update callers to use true/false), unless that would be confusing for
> other reasons (e.g. passing it through to other functions where the
> corresponding argument isn't boolean).
Yeah, I had been meaning to do that, but then I noticed that I'd have to
change c-common hook too, and thus even the C++ FE. I'm going to commit
this patch and then do the int -> bool change later on.
Marek
