On Tue, Sep 6, 2016 at 5:33 PM, Eric Gallager <eg...@gwmail.gwu.edu> wrote: > Ping? CC-ing an i386 maintainer since the patch mostly touches > i386-specific files. Also, to clarify, I say "warnings/errors" because > they start off as warnings in stage 1 but then become errors in stage > 2. Note also that my patch leaves out the part where I modify the > configure script to enable -Wnarrowing, because the rest of the code > isn't quite ready for that yet.
You are probably referring to [1]? It looks OK, modulo: +DEF_TUNE (X86_TUNE_QIMODE_MATH, "qimode_math", ~(0U)) where parenthesis are not needed. Please resubmit the patch with a ChangeLog entry, as instructed in [2] [1] https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02129.html [2] https://gcc.gnu.org/contribute.html#patches Uros. > On 8/31/16, Eric Gallager <eg...@gwmail.gwu.edu> wrote: >> In https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01526.html I tried >> enabling -Wnarrowing when building GCC and produced a log of the >> resulting (uniq-ed) warnings/errors. The attached patch here fixes >> some of them by using the 'U' suffix to make certain constants >> unsigned so they don't become negative when applying the '~' operator >> to them. After applying, there were still some narrowing issues >> remaining that would have required modifying gcc/optc-gen.awk to fix >> properly, but that looked too complicated so I'm avoiding it for now. >> Still, at least by patching the files I did patch, I allowed bootstrap >> to continue a little farther... >> >> Thanks, >> Eric Gallager >>
