On 09/05/2016 09:55 AM, Bernd Schmidt wrote:
On 09/05/2016 12:52 PM, Marek Polacek wrote:
On Mon, Sep 05, 2016 at 12:35:13PM +0200, Bernd Schmidt wrote:
On 09/02/2016 05:13 PM, Marek Polacek wrote:
diff --git gcc/doc/invoke.texi gcc/doc/invoke.texi
index 87da1f1..38d55d4 100644
--- gcc/doc/invoke.texi
+++ gcc/doc/invoke.texi
@@ -5437,8 +5437,8 @@ if (a < 0 && a < 0) @{ @dots{} @}
@opindex Wlogical-not-parentheses
@opindex Wno-logical-not-parentheses
Warn about logical not used on the left hand side operand of a
comparison.
-This option does not warn if the RHS operand is of a boolean type.
Its
-purpose is to detect suspicious code like the following:
+This option does not warn if the right operand is considered to be
a Boolean
+expression. Its purpose is to detect suspicious code like the
following:
I think "Boolean" shouldn't be capitalized. The patch looks ok to me
otherwise.
No strong opinions, but looking at
https://en.wikipedia.org/wiki/Boolean_expression
I see that it's capitalized there, so I think let's keep "Boolean".
I looked at other occurrences in this file, and they are lower-case.
Across the other texi files upper-case is also the exception. Let's ask
Sandra for a ruling?
Ummmm. There seems to be precedent for both capitalizing it and not.
The C standard doesn't capitalize it (but the only place I could find
where "boolean" used in a context where it wouldn't be capitalized
anyway, such as the first word in a section title, is the index). The
C++ standard isn't consistent, using both "Boolean" and "boolean" (and
sometimes even on the same page). The documents I have handy are older
drafts, though; maybe that has been cleaned up in current/final versions.
Looking at some other languages, the Python documentation capitalizes:
https://docs.python.org/3/library/stdtypes.html
But the Scheme specification editors deliberately chose not to do so:
http://www.r6rs.org/r6rs-editors/2007-April/002143.html
The Haskell specification also uses lowercase:
https://www.haskell.org/onlinereport/haskell2010/haskellch6.html#x13-1170006.1
Mark-Jason Dominus gave the matter some serious thought:
http://blog.plover.com/lang/Boolean.html
Anyway, I will be happy either way as long as the documentation is
consistent.
-Sandra
