On Fri, Aug 19, 2016 at 02:01:29PM +0200, Marek Polacek wrote: > On Fri, Aug 19, 2016 at 01:21:14PM +0200, Marek Polacek wrote: > > On Thu, Aug 18, 2016 at 07:31:12PM +0100, Manuel López-Ibáñez wrote: > > > Does this warning make sense if !(lang_GNU_C() || lang_GNU_CXX()) ? > > > > I don't think so, it's meant for C/C++ only. I added a better check. > > Well, maybe the warning could also work for ObjC and ObjC++, but since I > haven't included any testcases for these languages so far, maybe better to > restrict it for C and C++ only.
IMHO it should be also on for ObjC and ObjC++, even if there is no test coverage (though, it would be good to add some eventually). > Go switch statements look very similar to C/C++ switches, but they don't > fall through, so the warning would be pointless. No idea about Fortran and > Ada. Go don't fall through by default, but there is fallthrough keyword for falling through. And Fortran SELECT CASE doesn't fall through. Jakub