On Tue, Jul 26, 2016 at 01:51:33PM +0000, Robert Suchanek wrote:
> Hi,
>
> > On May 5, 2016, at 8:14 AM, Robert Suchanek <robert.sucha...@imgtec.com>
> > wrote:
> > >
> > > I'm resending this patch as it has been rebased and updated. I reverted a
> > change
> > > to check_effective_target_vect_call_lrint procedure because it does not
> > > use
> > > cached result.
> >
> > Ok.
> >
> > Please ensure that the compilation flag is mixed into the test case name so
> > that as you iterate over them, the test case names are unique.
>
> An effective target is likely to have a unique flag to enable a given set of
> SIMD operations and this is mixed into test case names.
>
> I double-checked this with mips-mti-linux-gnu where auto-vectorization tests
> can be run twice i.e. for -mmsa and -mpaired-single.
>
> The patch was rebased once again and tested on x86_64-unknown-linux-gnu.
>
> Committed as r238755.
unfortunately this broke make check-c
RUNTESTFLAGS='vect.exp=*no-vfa-vect-dv-2.c
--target_board=unix\{-m32,-m64\}', causing the check if
vect_aligned_arrays to be cached between the -m64 and -m32 variants
which is incorrect at least on my machine if you actually run that test
for -m32 and -m64 you get different results. In both case et_index is 0
so you use the cached value the second time, but that's not correct
because the options changed.
I suspect this also causes some random vectorizer tests to appear and
disappear during regression testing with the same -m64 and -m32, but I'm
not absolutely sure of that part.
Thanks!
Trev
>
> Thanks and regards,
> Robert
>
