On Thu, Aug 11, 2016 at 04:55:34PM +0200, Stanislaw Halik wrote: > On 2016-08-11 Thu 16:33, Kai Tietz wrote: > >Hello Stanislaw. > > > >patch is ok. Nevertheless there is a ChangeLog entry missing for it. > >It is mandatory to be provided for submissions to gcc. > > ChangeLog: > > PR target/66488 > * gcc/config/i386/xm-mingw32.h (HOST_BITS_PER_PTR): specify pointer > size as distinct from sizeof long, for the use in gcc/ggc-page.c
gcc/ directory has its own ChangeLog, the filename is relative against that. The description should start after ): with capital letter, end with . And the description is what has changed, not why. So PR target/66488 * config/i386/xm-mingw32.h (HOST_BITS_PER_PTR): Define if __x86_64__. or so would be better. Jakub