On Tue, Aug 09, 2016 at 08:33:49PM +0900, Oleg Endo wrote: > On Mon, 2016-08-08 at 13:39 -0400, Trevor Saunders wrote: > > > > First sizeof std::string is 32 on x86_64, a char *, a size_t for the > > length, and a 16 byte union of a size_t for allocated size and a 16 > > byte buffer for short strings. I suppose some of this is required by > > the C++ standard, > > I recommend checking what others have figured regarding that matter > https://github.com/elliotgoodrich/SSO-23
I think one of the big mistakes in the C++ stl strings is that they try to shove stack allocated strings where you want an internal buffer for SSO and a class to put in structs into the same type. imho it would be better to have std::string for the second use case, and a separate std::stack_string or something for the first case. > > but I doubt we really need to care about strings longer than 2^32 in > > gcc. If we put the length and allocated size in the buffer, > > and have a separate class for stack allocated buffers I think we can > > have a string that is just sizeof void *. > > This idea has one flaw in that it does not allow having objects by > value. It essentially *requires* one to *always* allocate them on the > heap via new/delete. Being able to store objects by value is useful in > many situations. So if you do the above, the next logical step that > will follow is a smart-pointer-like wrapper that allows value > semantics. Because eventually somebody will want that operator == or > operator < e.g. for associative containers. If what you want is the ability to put the buffer on the stack instead of the heap then I think a stack_string class that interoperates with your string class is the thing you want. I don't really see anything wrong with a string class being a really fancy smart pointer that has a bunch of useful string stuff on it. As for operator == I'd be fairly ok with that, other than it hiding a O(N) operation in ==. > > > > Second it would be useful performance wise to have a std::string_view > > type class, but that is c++14 or 17? only so we'd need to import it > > into gcc or something. > > http://en.cppreference.com/w/cpp/experimental/basic_string_view > http://en.cppreference.com/w/cpp/string/basic_string_view > > It's "funny" that GCC contains a C++ stdlib implementation and so > little is actually used by GCC itself. Regretably necessary sure, but I'm not sure its funny. The first big problem with using the stl is that the subset available in C++98 isn't that great, you could maybe hack up libstdc++ so that you can use newer types just without the bits that use newer language features, but that would take some work. The other big problem is that the stl is often too general, and tries to be too simple. std::string is actually a good example of both of those problems. There's really no reason it should use size_t instead of uint32_t for the string length / capacity. It would also be a lot better if it had separate types for strings where you want an internal buffer or don't. Trev
