On Wed, Jul 27, 2016 at 06:53:39PM +0200, Marek Polacek wrote:
> --- gcc/gcc/var-tracking.c
> +++ gcc/gcc/var-tracking.c
> @@ -1056,6 +1056,8 @@ adjust_mems (rtx loc, const_rtx old_rtx, void *data)
> ? GET_MODE_SIZE (amd->mem_mode)
> : -GET_MODE_SIZE (amd->mem_mode),
> GET_MODE (loc)));
> + /* XXX Really fallthru? */
> + gcc_fallthrough ();
> case POST_INC:
> case POST_DEC:
> if (addr == loc)
> @@ -1076,6 +1078,8 @@ adjust_mems (rtx loc, const_rtx old_rtx, void *data)
> return addr;
> case PRE_MODIFY:
> addr = XEXP (loc, 1);
> + /* XXX Really fallthru? */
> + gcc_fallthrough ();
> case POST_MODIFY:
> if (addr == loc)
> addr = XEXP (loc, 0);
Indeed, these two are intentional fallthrus. But, can you just add
/* FALLTHRU */
comment in there, rather than gcc_fallthrough () or similar?
Patch preapproved.
Jakub
