On Fri, Jul 29, 2016 at 11:47:18PM +0800, Chung-Lin Tang wrote:
> On 2016/7/21 07:13 PM, Jakub Jelinek wrote:
> > Better put every && on a separate line if the whole if (...) doesn't fit
> > on a single line.
> >
> >> > + && !n->sym->attr.cray_pointer
> >> > + && !n->sym->attr.cray_pointee)
> > This is too ugly. I'd instead move the if after the cray pointer/pointee
> > tests, i.e.
> > if (n->sym->attr.cray_pointer)
> > gfc_error (...);
> > else if (n->sym->attr.cray_pointee)
> > gfc_error (...);
> > else if (n->sym->attr.flavor == FL_VARIABLE
> > && !n->sym->as
> > && !n->sym->attr.pointer)
> > gfc_error (...);
> >
>
> Hi Jakub, I've adjusted the patch like you suggested.
>
> Patch has been re-tested and applied to gomp-4_0-branch,
> okay for trunk as well?
Ok with suitable ChangeLog entry.
Jakub
