On Mon, Aug 8, 2016 at 7:04 PM, Jeff Law <l...@redhat.com> wrote: > On 08/08/2016 05:58 AM, Marek Polacek wrote: >> >> On Mon, Aug 08, 2016 at 12:56:20PM +0100, Roger Sayle wrote: >>> >>> >>> The following patch is an attempt to finally fully close PR >>> middle-end/21137. >>> As explained in the PR, my original patch from 2006 didn't handle the >>> case >>> where there's a sign preserving NOP in the tree. Easily fixed by calling >>> tree_strip_nop_conversions at the appropriate point in fold-const.c. >>> Most of this patch is the resulting re-indentation. >> >> >> Shouldn't this be rather handled through the match.pd interface? > > I don't see this transformation in match.pd. So the whole transformation > would need to be pulled out of fold-const.c and reimplemented in the > match.pd framework. > > Roger, are you up for that? match.pd is certainly where we want much of > this kind of stuff happening.
Moving shouldn't be a requirement for improving things here, so I think the patch is ok as-is. Richard. > jeff
