The libgo tests on ppc64le and ppc64 have all been failing in
gcc-testresults since this change went in and continues to fail after
the recent fixes for failures on other platforms.
Built myself and got the same failures. I set keep=true in gotest to
save the test dirs. Just running a single package:
make bufio/check
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not
found
Keeping gotest9734
FAIL: bufio
Makefile:3645: recipe for target 'bufio/check' failed
make: *** [bufio/check] Error 1
boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ ls
/home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
/home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ file
/home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go
/home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go: ASCII text
The gotest saved test directory contains the go file they are looking for.
ls ./powerpc64le-linux/libgo/gotest9734/test/bufio.go
./powerpc64le-linux/libgo/gotest9734/test/bufio.go
Likewise for all when doing make check-target-libgo
=== libgo tests ===
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not
found
Keeping gotest10016
FAIL: bufio
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bytes/buffer.go
not found
Keeping gotest10106
FAIL: bytes
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/context/context.go
not found
Keeping gotest10166
FAIL: context
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/errors/errors.go
not found
Keeping gotest10226
FAIL: errors
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/expvar/expvar.go
not found
Keeping gotest10286
FAIL: expvar
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/flag/flag.go not found
Keeping gotest10346
FAIL: flag
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/fmt/doc.go not found
Keeping gotest10436
FAIL: fmt
file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/html/entity.go not
found
Keeping gotest10506
FAIL: html
.....
On 08/05/2016 07:36 PM, Ian Lance Taylor wrote:
Go packages use build tags (see the section on Build Constraints at
https://golang.org/pkg/go/build/) to select which files to build on
specific systems.
Previously the libgo Makefile explicitly listed the set of files to
compile for each package. For packages that use build tags, this
required a lot of awkward automake conditionals in the Makefile.
This patch changes the build to look at the build tags in the files.
The new shell script libgo/match.sh does the matching. This required
adjusting a lot of build tags, and removing some files that are never
used. I verified that the exact same sets of files are compiled on
x86_64-pc-linux-gnu. I also tested the build on i386-sun-solaris
(building for both 32-bit and 64-bit).
Writing match.sh revealed some bugs in the build tag handling that
already exists, in a slightly different form, in the gotest shell
script. This patch fixes those problems as well.
The old code used automake conditionals to handle systems that were
missing strerror_r and wait4. Rather than deal with those in Go,
those functions are now implemented in runtime/go-nosys.c when
necessary, so the Go code can simply assume that they exist.
The os testsuite looked for dir_unix.go, which was never built for
gccgo and has now been removed. I changed the testsuite to look for
dir.go instead.
Note that if you have an existing build directory, you will have to
remove all the .dep files in TARGET/libgo after updating to this
patch. There isn't anything that will force them to update
automatically.
Bootstrapped on x86_64-pc-linux-gnu and i386-sun-solaris. Ran Go
testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
