On 08/01/2016 06:02 AM, Martin Liška wrote:
On 07/28/2016 11:26 PM, Joseph Myers wrote:
On Mon, 18 Jul 2016, Martin Liška wrote:
Well, I can imaging a guard which will test whether
"$objdir/../../params.options" file exits, and if so, then the tests are
executed? Is it acceptable approach?
The correct way to test for build-tree testing is [info exists
TESTING_IN_BUILD_TREE]. When testing outside the build tree, you should
not assume anything about directories outside of the test and source
directories, meaning you should not test for existence of paths in
$objdir/../ in that case.
Thank you for the hint, I'm attaching patch.
(The preferable approach is to factor out the code generating this file so
it can be run from the testsuite. Then you don't need to distinguish
build-tree and other testing at all.)
That would be the best approach, but I've got quite limited experience with
DejaGNU,
I would postpone it and write it on my TODO list.
May I install the suggested patch?
Yes.
jeff
