On 07/21/2016 03:15 AM, Ilya Enkovich wrote:
In my list I see #1, #4, and #5 are not approved.
So I think Richi wanted to see param control for the new options; Joseph
wanted the new options properly documented in invoke.texi; I had a few
higher level questions which you answered. Your updated patch #1 added
param control and invoke.texi documentation. So IMHO, #1 is approved.
#4 had some whitespace nits and needed some light doc improvements which
you've done. I think the only real implementation issue was computing
costs in a single scan vs restarting the scan. I was OK with the single
scan approach you took -- not sure how strongly Richi feels about
restarting the scan. Seems like Richi needs to chime in on that topic.
I'm hoping to finish reviewing the update to #5 today.
jeff
