On Tue, Jul 12, 2016 at 01:24:15PM +0200, Bernd Schmidt wrote:
> On 07/11/2016 09:43 PM, Marek Polacek wrote:
> > This warning is enabled by default for C/C++. I was more inclined to put
> > this
> > into -Wall, but our common.opt machinery doesn't seem to allow that (ugh!).
>
> Add me to the list of folks opposed to enabling this unconditionally or as
> part of any other -W flag. The false positive rate would be enormous as
> shown by your patch series.
I feel that, given all the pushback, I have to explain that it was never my
intent to enable this by default. I was thinking of -Wall/-Wextra (given
-Wmisleading-indentation is in -Wall). It's been enabled by default only to
get better testing coverage when doing various bootstraps and I failed to
move it to -Wextra, or even out of it.
As discussed elsewhere, I/we'll have to suppress the warning for various
"falls through" comments, which should cut the verbosity substantially.
Whether to put this warning into -Wall/-Wextra when that's done is still
to be discussed, but we all know that if a warning is out of -Wall/-Wextra,
no one will use it.
Marek
