On Fri, Jul 08, 2016 at 09:31:33AM -0400, Michael Meissner wrote:
> * gcc.target/powerpc/p9-lxvx-stxvx-3.c: Add -mfloat128 option.
Is that the only testcase that needs updating?
> --- gcc/config/rs6000/rs6000-cpus.def (revision 238127)
> +++ gcc/config/rs6000/rs6000-cpus.def (working copy)
> @@ -63,7 +63,6 @@
> /* Add ISEL back into ISA 3.0, since it is supposed to be a win. Do not add
> P9_MINMAX until the hardware that supports it is available. */
> #define ISA_3_0_MASKS_SERVER (ISA_2_7_MASKS_SERVER \
> - | OPTION_MASK_FLOAT128_HW \
Please add a comment for this as well?
> /* IEEE 128-bit floating point hardware instructions imply enabling
> __float128. */
> if (TARGET_FLOAT128_HW
> - && (rs6000_isa_flags & (OPTION_MASK_P9_VECTOR
> - | OPTION_MASK_DIRECT_MOVE
> - | OPTION_MASK_UPPER_REGS_DI
> - | OPTION_MASK_UPPER_REGS_DF
> - | OPTION_MASK_UPPER_REGS_SF)) == 0)
> + && (rs6000_isa_flags & ISA_3_0_MASKS_IEEE) != ISA_3_0_MASKS_IEEE)
> {
> if ((rs6000_isa_flags_explicit & OPTION_MASK_FLOAT128_HW) != 0)
> error ("-mfloat128-hardware requires full ISA 3.0 support");
That is not the same thing... New one looks better, is this a bugfix?
The changelog doesn't say.
Okay for trunk and 6 with those nits fixed. Thanks,
Segher
