On 07/04/2016 02:19 PM, Dominik Vogt wrote: > Version 4 with the following change: > > * Rebased on top of the "Minor cleanup to > allocate_dynamic_stack_space" patch. The "Drop excess size > used for run time allocated stack variables." path needs an > update because it touches the dsame code as the patch in this > message. > > Ran the testsuite on s390x biarch, s390 and x86_64. > > On Fri, Jun 24, 2016 at 01:30:44PM +0100, Dominik Vogt wrote: >>> The only open question I'm aware of is the >>> stack-usage-2.c test. I guess foo3() will not generate >>> >>> stack usage might be ... bytes >>> >>> On any target anymore, and using alloca() with a constant size >>> results in "unbounded". It's unclear to me whether that message >>> is ever generated, and if so, how to trigger it. > > This point is still open. If nobody has more comments Andreas > will commit the (afaik already approved) patch soon and we can > clean up the test case in a follow up patch.
I would like to see an explicit approval before doing the commit. I think it would also make sense to let other target maintainers have a look whether this might cause any problems. Bye, -Andreas- > > Ciao > > Dominik ^_^ ^_^ >
